Apply unsafe_op_in_unsafe_fn to the standard library #136986
Conversation
|
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
rustbot
added
O-windows
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR! Looks like miri needs your blessings |
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
|
Fixing miri looks like it will be non-trivial (it seems to have some sensitivity to the target). I may not be able to get back to this for a couple days. |
|
Yeah these tests have some careful;y chosen normalization patterns as they show code spans from the standard library that can differ between targets. But the CI failure is due to code in |
These functions were changed to be safe in rust-lang#127763, but this particular UWP version was missed. Otherwise this causes unnecessary unsafe block warnings/errors.
ehuss
force-pushed
the
library-unsafe-fun
branch
from
35ca558 to
2830755
Compare
|
OK, I found a few minutes this morning to look at this. I updated the miri tests with what I think is the correct way to bless it. All the checktools.sh targets seem to pass. @RalfJung please let me know if it looks ok. |
|
Miri diff LGTM :) |
|
@bors r+ |
bors
added
S-waiting-on-bors
Apply unsafe_op_in_unsafe_fn to the standard library This applies unsafe_op_in_unsafe_fn to the standard library in preparation for updating to Rust 2024. Closes rust-lang#127747 (I think?) cc `@workingjubilee` I have been testing a variety of targets, and I feel like they are all pretty much covered. I'll continue doing some testing async, but I don't expect to catch any more.
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#125087 (Optimize `Seek::stream_len` impl for `File`) - rust-lang#136986 (Apply unsafe_op_in_unsafe_fn to the standard library) - rust-lang#137012 (add docs and ut for bootstrap util cc-detect) - rust-lang#137072 (Load all builtin targets at once instead of one by one in check-cfg) - rust-lang#137102 (Rework `name_regions` to not rely on reverse scc graph for non-member-constrain usages) - rust-lang#137112 (Don't project into `NonNull` when dropping a `Box`) - rust-lang#137114 (Add an example for `std::error::Error`) - rust-lang#137117 (Fix test that relies on error language) - rust-lang#137119 (fix broken `x {doc, build} core`) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#136986 (Apply unsafe_op_in_unsafe_fn to the standard library) - rust-lang#137012 (add docs and ut for bootstrap util cc-detect) - rust-lang#137072 (Load all builtin targets at once instead of one by one in check-cfg) - rust-lang#137102 (Rework `name_regions` to not rely on reverse scc graph for non-member-constrain usages) - rust-lang#137112 (Don't project into `NonNull` when dropping a `Box`) - rust-lang#137114 (Add an example for `std::error::Error`) - rust-lang#137117 (Fix test that relies on error language) - rust-lang#137119 (fix broken `x {doc, build} core`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#136986 - ehuss:library-unsafe-fun, r=Noratrieb Apply unsafe_op_in_unsafe_fn to the standard library This applies unsafe_op_in_unsafe_fn to the standard library in preparation for updating to Rust 2024. Closes rust-lang#127747 (I think?) cc ``@workingjubilee`` I have been testing a variety of targets, and I feel like they are all pretty much covered. I'll continue doing some testing async, but I don't expect to catch any more.
This applies unsafe_op_in_unsafe_fn to the standard library in preparation for updating to Rust 2024.
Closes #127747 (I think?) cc @workingjubilee
I have been testing a variety of targets, and I feel like they are all pretty much covered. I'll continue doing some testing async, but I don't expect to catch any more.